Alex Lourie has uploaded a new change for review.
Change subject: packaging: replaced hard-coded service name with a const
..
packaging: replaced hard-coded service name with a const
Change-Id: Ide45b6f39132b2cab9859828ff94e8788
Liron Aravot has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Patch Set 2: (2 inline comments)
mkublin, when user performs recovery he is performing re
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: hardware: fix typo in amd virtualization detection
..
vdsm: hardware: fix typo in amd virtualization detection
Change-Id: I2deb8f7ab0f306b15edc7b82
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: hardware: fix typo in amd virtualization detection
..
Patch Set 1: Verified; Looks good to me, approved
Reported and tested by Cristian Falcas.
--
To view,
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: hardware: fix typo in amd virtualization detection
..
vdsm: hardware: fix typo in amd virtualization detection
Change-Id: I2deb8f7ab0f306b15edc7b8238325ef6
Vered Volansky has posted comments on this change.
Change subject: core: ImportVm cleanup: saveDiskImageDynamic
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9615
To u
Vered Volansky has posted comments on this change.
Change subject: core: ImportVm cleanup: iterate maps values()
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9616
To
Vered Volansky has posted comments on this change.
Change subject: core: ImportVm test cleanup: remove spring
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9617
To uns
Vered Volansky has posted comments on this change.
Change subject: core: ImportVm test cleanup: stop spying
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9618
To unsub
Roy Golan has posted comments on this change.
Change subject: REST: fix VmMapper of protection deletion
..
Patch Set 1: Verified
verified setting true + false with
curl -X PUT -H "Content-Type: application/xml" --user admin@in
Vered Volansky has posted comments on this change.
Change subject: core: ImportVm test cleanup: make constant static
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9619
ofri masad has posted comments on this change.
Change subject: core: Fix getQuotaConsumptionParameters redundant calls
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9656
To unsubscribe, visit http://gerrit.
ofri masad has posted comments on this change.
Change subject: webadmin: Add empty quota validator to update-VM
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/mod
Allon Mureinik has posted comments on this change.
Change subject: REST: fix VmMapper of protection deletion
..
Patch Set 1: Looks good to me, but someone else must approve
Looks fine to me, but let's get mpasternak's ack?
--
Roy Golan has uploaded a new change for review.
Change subject: REST: fix VmMapper of protection deletion
..
REST: fix VmMapper of protection deletion
fix wrong behaviour which also failed tests with NPE
Change-Id: Ibb2c1402b23
Allon Mureinik has posted comments on this change.
Change subject: engine: Cleanup network commands
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9546
To unsubscribe,
Vered Volansky has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Patch Set 2: (1 inline comment)
Fi
Vered Volansky has posted comments on this change.
Change subject: core: ImportVm cleanup: extract VM.hasImages()
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.
Vered Volansky has posted comments on this change.
Change subject: core: ImagesHandler.setDiskAlias early return
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9658
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: Update the commons-lang 2.6
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9268
To unsubscribe, visit http://gerrit.
Sharad Mishra has posted comments on this change.
Change subject: WIP: cpu host feature
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/gwt-common/src/main
Moran Goldboim has posted comments on this change.
Change subject: packaging: engine-upgrade - check for free space before upgrade
..
Patch Set 3:
Bug url is missing.
--
To view, visit http://gerrit.ovirt.org/9744
To unsubscri
Moti Asayag has posted comments on this change.
Change subject: webadmin: Add Network to add role dialog
..
Patch Set 3: (7 inline comments)
File
frontend/webadmin/modules/u
Alex Lourie has posted comments on this change.
Change subject: packaging: engine-upgrade - check for free space before upgrade
..
Patch Set 3: Looks good to me, but someone else must approve
Looks good, please put verify flag.
Moti Asayag has posted comments on this change.
Change subject: webadmin: Add option to mark network as public
..
Patch Set 3: (3 inline comments)
File
frontend/webadmin/mod
Roy Golan has posted comments on this change.
Change subject: core: remove unmanaged devices on down VM event
..
Patch Set 2: Verified
(2 inline comments)
File
backend/mana
Roy Golan has posted comments on this change.
Change subject: core: remove unmanaged devices on down VM event
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9756
To unsubscribe, visit http://gerrit.ovirt.org
Roy Golan has uploaded a new change for review.
Change subject: core: remove unmanaged devices on down VM event
..
core: remove unmanaged devices on down VM event
unmanaged devices where being removed only by direct stop/shutdow
Asaf Shakarchi has posted comments on this change.
Change subject: core: Update the commons-lang 2.6
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9268
To unsubscribe, visit http://gerrit.
Moti Asayag has posted comments on this change.
Change subject: webadmin: Setup Network- doesn't show the correct boot protocol.
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Sharad Mishra has posted comments on this change.
Change subject: WIP: cpu host feature
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscripts/upgrade/pre_upgrade/
Alissa Bonas has posted comments on this change.
Change subject: core: ImportVm cleanup: extract VM.hasImages()
..
Patch Set 1: (1 inline comment)
pls see comment in code...
...
Alissa Bonas has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Patch Set 2: (1 inline comment)
pls see my comment in code
.
Alissa Bonas has posted comments on this change.
Change subject: core: ImagesHandler.setDiskAlias early return
..
Patch Set 3: (1 inline comment)
File
backend/manager/module
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2948/
Build Number: 2948
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,567
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2946/
Build Number: 2946
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,565
-
Changes
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2947/
Build Number: 2947
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,566
-
Changes
Eli Mesika has submitted this change and it was merged.
Change subject: core:Add a script that displays async ...(#868672)
..
core:Add a script that displays async ...(#868672)
Adding a fn_db_get_async_tasks function to the dat
Eli Mesika has posted comments on this change.
Change subject: core:Add a script that displays async ...(#868672)
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8736
To unsubscrib
Eli Mesika has submitted this change and it was merged.
Change subject: core:Power Management: restart operatio..(#865385)
..
core:Power Management: restart operatio..(#865385)
core:Power Management: restart operation fails occ
Eli Mesika has posted comments on this change.
Change subject: core:Power Management: restart operatio..(#865385)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8620
To unsubscrib
Daniel Erez has posted comments on this change.
Change subject: core: Fix filling in disk aliases in BLL messages
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9446
To unsubscribe, visit h
Daniel Erez has posted comments on this change.
Change subject: webadmin: clone JP translation split to two line in new VM
dialog
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9742
To uns
Michael Kublin has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Patch Set 2: I would prefer that you didn't submit this
Perform a full override for met
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI Plugins PoC, revision 7
..
Patch Set 2:
Juan, thank you for your comments, in general I agree with your points. Using
RequestBuilder.setUser/setPas
Daniel Erez has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Doron Fediuck has submitted this change and it was merged.
Change subject: core: fix for cpuPinning
..
core: fix for cpuPinning
vcpu number was matched only as single decimal limit, so if you have
more than 10 vcpus, pinning vc
Doron Fediuck has posted comments on this change.
Change subject: core: fix for cpuPinning
..
Patch Set 3: Verified; Looks good to me, approved
Rebased patch.
--
To view, visit http://gerrit.ovirt.org/9738
To unsubscribe, visi
Doron Fediuck has posted comments on this change.
Change subject: core: fix for cpuPinning
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9738
To unsubscribe, visit http://gerrit.ovirt.org/
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2944/
Build Number: 2944
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,563
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2945/
Build Number: 2945
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,564
-
Changes
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: action and type params
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Alissa Bonas has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Patch Set 2: (1 inline comment)
pls see my question regarding hardcoded returning true on
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Fixing npe at notification service log
..
tools: Fixing npe at notification service log
Both MAIL_FORM and MAIL_USER are not mandatory to send
a
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Fixing npe at notification service log
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9726
To unsubscribe
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Setup Network- doesn't show the correct boot protocol.
..
webadmin: Setup Network- doesn't show the correct boot protocol.
The fix in commit 30f20efd64
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm test cleanup: make constant static
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm test cleanup: stop spying
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9618
To unsubsc
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm test cleanup: remove spring
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9617
To unsub
Liron Aravot has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Patch Set 2: (1 inline comment)
File
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: iterate maps values()
..
Patch Set 3: (1 inline comment)
File
backend/manager/module
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: saveDiskImageDynamic
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
.
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: DAO accessors
..
Patch Set 3: No score
--
To view, visit http://gerrit.ovirt.org/9614
To unsubscribe, visit http://gerrit.ovirt.org/settin
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: DAO accessors
..
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
Liron Aravot has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Patch Set 2: (1 inline comment)
File
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Fixing npe at notification service log
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9726
To unsubscribe
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: fix modifiers
..
Patch Set 3: Looks good to me, approved
Originally, log should be get from the commandBase and not declared in the
impor
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup on notification service resource closing
..
core: Cleanup on notification service resource closing
This patch introduces DbUtils for DB-r
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9740
To un
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: DB connections improvement at notifier
..
tools: DB connections improvement at notifier
A performance issue (and maybe not the only one) exists
Yair Zaslavsky has posted comments on this change.
Change subject: tools: DB connections improvement at notifier
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9735
To unsubscribe
Yair Zaslavsky has posted comments on this change.
Change subject: tools: DB connections improvement at notifier
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9735
To unsubscribe
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9740
To un
Juan Hernandez has submitted this change and it was merged.
Change subject: Packaging: remove CABaseDirectory from
engine-config-install.properties
..
Packaging: remove CABaseDirectory from engine-config-install.properties
The
Juan Hernandez has posted comments on this change.
Change subject: Packaging: remove CABaseDirectory from
engine-config-install.properties
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks and
Juan Hernandez has posted comments on this change.
Change subject: Packaging: remove CABaseDirectory from
engine-config-install.properties
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/96
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: extract VM.hasImages()
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
...
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: extract VM.hasImages()
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Liron Aravot has uploaded a new change for review.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
..
Reinitialize DC doesn't connect all hosts to the new master(#880180)
When reinitializing
Sharad Mishra has posted comments on this change.
Change subject: core: change gracefully shutdown message (#854218)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9706
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: parameter hiding
..
Patch Set 3: (2 inline comments)
File
backend/manager/modules/bl
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: unwrap else blocks
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9611
To unsubscribe, visit http://
Alexey Chub has uploaded a new change for review.
Change subject: webadmin: Fix appearance of a "Test" button on host dialog
(#877814)
..
webadmin: Fix appearance of a "Test" button on host dialog (#877814)
Change-Id: Ia6b8e6cc
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-upgrade - check for free space before upgrade
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
A couple of
Ofer Schreiber has uploaded a new change for review.
Change subject: packaging: engine-upgrade - check for free space before upgrade
..
packaging: engine-upgrade - check for free space before upgrade
Add pre-run check to engine-
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-upgrade - check for free space before upgrade
..
Patch Set 1: Looks good to me, but someone else must approve
Some minor whitespace issues.
-
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
..
Patch Set 4: (1 inline comment)
File
backend/manager/
Eduardo has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin,userportal: fix LoginPopupView style in IE9
..
webadmin,userportal: fix LoginPopupView style in IE9
Editors labels must be manually hidden only f
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: fix LoginPopupView style in IE9
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9652
T
Moti Asayag has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9740
To unsubscribe, vi
Itamar Heim has posted comments on this change.
Change subject: [wip] webadmin: enable the spice-xpi extension for chrome
..
Patch Set 1:
just wondering - is this using the same XPI rpm firfox uses?
--
To view, visit http://ge
Ravi Nori has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9740
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
..
Patch Set 5:
Followed Ravi's comments + removed TWS
--
To view, visit http://gerrit.ovirt.org/9740
To
Ravi Nori has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
...
Ravi Nori has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
..
Patch Set 3: (1 inline comment)
Please see my comment
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: fix LoginPopupView style in IE9
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9652
T
Moti Asayag has posted comments on this change.
Change subject: restapi: #868626 - All-Content Header
..
Patch Set 2: (4 inline comments)
File
backend/manager/modules/restap
Roy Golan has submitted this change and it was merged.
Change subject: core: update internal keys of manage-domains
..
core: update internal keys of manage-domains
due to latest commons-configuration update a key in property fi
Roy Golan has posted comments on this change.
Change subject: core: update internal keys of manage-domains
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9743
To unsubscribe, visi
1 - 100 of 189 matches
Mail list logo
