Alissa Bonas has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
......................................................................
Patch Set 2: (1 inline comment)
pls see my comment in code
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
Line 83: }
Line 84:
Line 85: @Override
Line 86: protected boolean performConnectOperations(VDS vds) {
Line 87: if (vds.getId().equals(getVds().getId())
You might get here null pointer exception for vds.getId() by not making sure
first that vds is not null...
also perhaps it will be good to name this method differently - this method
doesn't actually perform the connect operations, but rather just checks if it's
necessary to perform it, so maybe something like isConnectOperationRequired.
Line 88: ||
StorageHelperDirector.getInstance().getItem(getStorageDomain().getstorage_type())
Line 89:
.ConnectStorageToDomainByVdsId(getNewMaster(false), vds.getId())) {
Line 90: return true;
Line 91: }
--
To view, visit http://gerrit.ovirt.org/9748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3733b732b37f3a687b24f90bfdb1799757434d75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
