Ravi Nori has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
......................................................................
Patch Set 3: (1 inline comment)
Please see my comment
....................................................
File
backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
Line 291: dbUser.setuser_id(userId);
Line 292: dbUser.setemail(rs.getString("email"));
Line 293: }
Line 294: } finally {
Line 295: DbUtils.closeQuietly(rs,connection);
ps is not closed here. Should be DbUtils.closeQuietly(rs, ps, connection);
Line 296: }
Line 297: return dbUser;
Line 298: }
Line 299:
--
To view, visit http://gerrit.ovirt.org/9740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c4e156123
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
