Maor Lipchuk has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 80: lun.setLunConnections(new
ArrayList<storage_server_connections>(getDbFacade()
Line 81: .getStorageServerConnectionDao()
Line 82: .getAllForLun(lun.getLUN_id())));
Line 83: }
Line 84: return lun.getLunConnections().isEmpty() ? StorageType.FCP :
lun.getLunConnections().get(0).getstorage_type();
> lun.getLunConnections().get(0).getstorage_type() assume that all LUN
> connections are of the same type. This is false. The same LUN can be exposed
> by different transports.
I don't think that we support this kind of LUN right now, when we will, this
method should be changed according to this type of change.
> The empty connection list = FCP inference is False. A local LUN has no
> connections too.
When do we use local lun in the engine?
> Before plugging the LUN the host should be connected to the storage server
> using the proper type. if there are no connections there is no need for an
> explicit connection Assuming FCP is wrong and unnecessary at all.
I don't follow this comment.
Line 85: }
Line 86:
Line 87: protected boolean isDiskPassPciAndIdeLimit(Disk diskInfo) {
Line 88: List<VmNetworkInterface> vmInterfaces =
getVmNetworkInterfaceDao().getAllForVm(getVmId());
--
To view, visit http://gerrit.ovirt.org/9724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
