Sharad Mishra has posted comments on this change.
Change subject: WIP: cpu host feature
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
Line 333: </g:VerticalPanel>
Line 334: <g:Label
addStyleNames="{style.sectionLabel}"
text="{constants.runMigrationOptionsVmPopup}" />
Line 335: <g:VerticalPanel
width="100%" addStyleNames="{style.hostRunMigrationOptions}">
Line 336:
<e:EntityModelCheckBoxEditor ui:field="runVMOnSpecificHostEditor"
addStyleNames="{style.checkbox}" />
Line 337:
<e:EntityModelCheckBoxEditor ui:field="hostCpuEditor"
addStyleNames="{style.checkbox}" />
was able to build and deploy this patch, but did not see the hosttab. Is it
still under construction? I am not familiar with frontend.
Line 338:
<e:EntityModelCheckBoxEditor ui:field="dontMigrateVMEditor"
addStyleNames="{style.checkboxWithLongLabel}" />
Line 339: </g:VerticalPanel>
Line 340:
<e:EntityModelTextBoxEditor ui:field="cpuPinning"
addStyleNames="{style.cpuPinningStyle}"/>
Line 341: <g:HTML
ui:field="cpuPinningLabel"
addStyleNames="{style.explanationLabel},generalDialogComment" />
--
To view, visit http://gerrit.ovirt.org/9753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84bfce49a3b74595e68dfc1e7494dd20008ac9bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
