Moti Asayag has posted comments on this change.

Change subject: webadmin: Add Network to add role dialog
......................................................................


Patch Set 3: (7 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
Line 2458:         else if (entity instanceof GlusterVolumeEntity)
Line 2459:         {
Line 2460:             return ((GlusterVolumeEntity) entity).getId();
Line 2461:         }
Line 2462:         else if (entity instanceof NetworkView)
Done
Line 2463:         {
Line 2464:             return ((NetworkView) entity).getNetwork().getId();
Line 2465:         }
Line 2466:         return new Guid();


....................................................
File 
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 1073:     @DefaultStringValue("note: Permissions containing these 
operations should be associated with Data Center Object (or equivalent)")
Line 1074:     String 
notePermissionsContainigTheseOperationsShuoldAssociatDcOrEqualRoleTreeTooltip();
Line 1075: 
Line 1076:     @DefaultStringValue("note: Permissions containing these 
operations should be associated with Network Object (or equivalent)")
Line 1077:     String 
notePermissionsContainigTheseOperationsShuoldAssociatNetworkOrEqualRoleTreeTooltip();
Done
Line 1078: 
Line 1079:     @DefaultStringValue("Allow to move VM image to another Storage 
Domain")
Line 1080:     String allowToMoveVmImageToAnotherStorageDomainRoleTreeTooltip();
Line 1081: 


....................................................
File 
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Constants_es.properties
Line 38: allowToChangePropertiesOfTheVmPoolRoleTreeTooltip=Permitir el cambio 
de propiedades del MV-Pool
Line 39: allowToChangeStorageDomainStatusRoleTreeTooltip=Permitir el cambio de 
estatus del dominio de almacenamiento\: mantenimiento/activar; adjuntar/separar
Line 40: allowToChangeTemplatePropertiesRoleTreeTooltip=Permitir el cambio de 
propiedades de la plantilla
Line 41: allowToChangeVmCustomPropertiesRoleTreeTooltip=Permitir el cambio de 
propiedades personalizadas de la MV
Line 42: allowToConfigureHostsNetworkPhysicalInterfacesRoleTreeTooltip=Permitir 
configurar las interfaces f\u00EDsicas de la red del host (Nics)
Done
Line 43: allowToConfigureTemlateNetworkRoleTreeTooltip=Permitir configurar la 
red de plantillas
Line 44: allowToConfigureVMsNetworkRoleTreeTooltip=Permitir configurar la red 
de la MV
Line 45: allowToCopyTemplateBetweenStorageDomainsRoleTreeTooltip=Permitir la 
copia de la plantilla entre dominios de almacenamiento
Line 46: allowToCreateDataCenterRoleTreeTooltip=Permitir el crear el centro de 
datos


....................................................
File 
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Constants_fr.properties
Line 40: allowToChangePropertiesOfTheVmPoolRoleTreeTooltip=Autoriser le 
changement de propri\u00E9t\u00E9s du VM-Pool
Line 41: allowToChangeStorageDomainStatusRoleTreeTooltip=Autoriser le 
changement de statut du Domaine de stockage\: maintenance/activer; 
attacher/d\u00E9tacher
Line 42: allowToChangeTemplatePropertiesRoleTreeTooltip=Autoriser le changement 
de propri\u00E9t\u00E9s du mod\u00E8le
Line 43: allowToChangeVmCustomPropertiesRoleTreeTooltip=Autoriser le changement 
de propri\u00E9t\u00E9s personnalis\u00E9es de la VM
Line 44: 
allowToConfigureHostsNetworkPhysicalInterfacesRoleTreeTooltip=Autoriser la 
configuration des NIC de l'interface physique de l'h\u00F4te
Done
Line 45: allowToConfigureTemlateNetworkRoleTreeTooltip=Autoriser la 
configuration du R\u00E9seau de mod\u00E8les
Line 46: allowToConfigureVMsNetworkRoleTreeTooltip=Autoriser la configuration 
du r\u00E9seau de VM
Line 47: allowToCopyTemplateBetweenStorageDomainsRoleTreeTooltip=Autoriser la 
copie de Mod\u00E8le entre les Domaines de stockage
Line 48: allowToCreateDataCenterRoleTreeTooltip=Autoriser la cr\u00E9ation d'un 
Centre de donn\u00E9es


....................................................
File 
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Constants_ja.properties
Line 38: 
allowToChangePropertiesOfTheVmPoolRoleTreeTooltip=\u4EEE\u60F3\u30DE\u30B7\u30F3\u30D7\u30FC\u30EB\u30D7\u30ED\u30D1\u30C6\u30A3\u306E\u5909\u66F4\u3092\u8A31\u53EF
Line 39: 
allowToChangeStorageDomainStatusRoleTreeTooltip=\u30B9\u30C8\u30EC\u30FC\u30B8\u30C9\u30E1\u30A4\u30F3\u306E\u30B9\u30C6\u30FC\u30BF\u30B9\u306E\u5909\u66F4\u3092\u8A31\u53EF\uFF1Amaintenance/activate;
 attach/detach
Line 40: 
allowToChangeTemplatePropertiesRoleTreeTooltip=\u30C6\u30F3\u30D7\u30EC\u30FC\u30C8\u30D7\u30ED\u30D1\u30C6\u30A3\u306E\u5909\u66F4\u3092\u8A31\u53EF
Line 41: allowToChangeVmCustomPropertiesRoleTreeTooltip=VM 
\u30AB\u30B9\u30BF\u30E0\u30D7\u30ED\u30D1\u30C6\u30A3\u306E\u5909\u66F4\u3092\u8A31\u53EF
Line 42: 
allowToConfigureHostsNetworkPhysicalInterfacesRoleTreeTooltip=\u30DB\u30B9\u30C8\u306E\u30CD\u30C3\u30C8\u30EF\u30FC\u30AF\u7269\u7406\u30A4\u30F3\u30BF\u30FC\u30D5\u30A7\u30FC\u30B9
 (NIC) \u306E\u8A2D\u5B9A\u3092\u8A31\u53EF
Done
Line 43: 
allowToConfigureTemlateNetworkRoleTreeTooltip=\u30C6\u30F3\u30D7\u30EC\u30FC\u30C8\u30CD\u30C3\u30C8\u30EF\u30FC\u30AF\u306E\u8A2D\u5B9A\u3092\u8A31\u53EF
Line 44: 
allowToConfigureVMsNetworkRoleTreeTooltip=\u4EEE\u60F3\u30DE\u30B7\u30F3\u30CD\u30C3\u30C8\u30EF\u30FC\u30AF\u306E\u8A2D\u5B9A\u3092\u8A31\u53EF
Line 45: 
allowToCopyTemplateBetweenStorageDomainsRoleTreeTooltip=\u30B9\u30C8\u30EC\u30FC\u30B8\u30C9\u30E1\u30A4\u30F3\u9593\u306B\u304A\u3051\u308B\u30C6\u30F3\u30D7\u30EC\u30FC\u30C8\u306E\u30B3\u30D4\u30FC\u3092\u8A31\u53EF
Line 46: 
allowToCreateDataCenterRoleTreeTooltip=\u30C7\u30FC\u30BF\u30BB\u30F3\u30BF\u30FC\u306E\u4F5C\u6210\u3092\u8A31\u53EF


....................................................
File 
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Constants_zh_CN.properties
Line 38: 
allowToChangePropertiesOfTheVmPoolRoleTreeTooltip=\u5141\u8BB8\u4FEE\u6539 VM 
\u6C60\u7684\u5C5E\u6027
Line 39: 
allowToChangeStorageDomainStatusRoleTreeTooltip=\u5141\u8BB8\u4FEE\u6539\u5B58\u50A8\u57DF\u7684\u72B6\u6001\uFF1Amaintenance/activate;
 attach/detach
Line 40: 
allowToChangeTemplatePropertiesRoleTreeTooltip=\u5141\u8BB8\u4FEE\u6539\u6A21\u677F\u5C5E\u6027
Line 41: 
allowToChangeVmCustomPropertiesRoleTreeTooltip=\u5141\u8BB8\u4FEE\u6539\u865A\u62DF\u673A\u81EA\u5B9A\u4E49\u5C5E\u6027
Line 42: 
allowToConfigureHostsNetworkPhysicalInterfacesRoleTreeTooltip=\u5141\u8BB8\u4FEE\u6539\u4E3B\u673A\u7684\u7F51\u7EDC\u7269\u7406\u63A5\u53E3\uFF08NIC\uFF09
Done
Line 43: 
allowToConfigureTemlateNetworkRoleTreeTooltip=\u5141\u8BB8\u914D\u7F6E\u6A21\u677F\u7F51\u7EDC
Line 44: 
allowToConfigureVMsNetworkRoleTreeTooltip=\u5141\u8BB8\u914D\u7F6E\u865A\u62DF\u673A\u7F51\u7EDC
Line 45: 
allowToCopyTemplateBetweenStorageDomainsRoleTreeTooltip=\u5141\u8BB8\u5728\u5B58\u50A8\u57DF\u95F4\u590D\u5236\u6A21\u677F
Line 46: 
allowToCreateDataCenterRoleTreeTooltip=\u5141\u8BB8\u521B\u5EFA\u6570\u636E\u4E2D\u5FC3


....................................................
File 
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
Line 58: ActionGroup___LOGIN=Login Permissions
Line 59: ActionGroup___MANIPULATE_ROLES=Manipulate Roles
Line 60: ActionGroup___CREATE_STORAGE_POOL_NETWORK=Create
Line 61: ActionGroup___CONFIGURE_STORAGE_POOL_NETWORK=Edit Properties
Line 62: ActionGroup___CREATE_STORAGE_POOL_NETWORK=Create
Done
Line 63: ActionGroup___DELETE_STORAGE_POOL_NETWORK=Delete
Line 64: ActionGroup___CONFIGURE_ENGINE=Generic Configuration
Line 65: ActionGroup___CREATE_GLUSTER_VOLUME=Create Volume
Line 66: ActionGroup___MANIPULATE_GLUSTER_VOLUME=Manipulate Volume


--
To view, visit http://gerrit.ovirt.org/9536
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86243bdd22679ae4cd25be647acd4a56cd0b601f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to