Eduardo has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 80: lun.setLunConnections(new
ArrayList<storage_server_connections>(getDbFacade()
Line 81: .getStorageServerConnectionDao()
Line 82: .getAllForLun(lun.getLUN_id())));
Line 83: }
Line 84: return lun.getLunConnections().isEmpty() ? StorageType.FCP :
lun.getLunConnections().get(0).getstorage_type();
lun.getLunConnections().get(0).getstorage_type() assume that all LUN
connections are of the same type. This is false. The same LUN can be exposed by
different transports.
The empty connection list = FCP inference is False. A local LUN has no
connections too.
Before plugging the LUN the host should be connected to the storage server
using the proper type.
if there are no connections there is no need for an explicit connection
Assuming FCP is wrong and unnecessary at all.
Line 85: }
Line 86:
Line 87: protected boolean isDiskPassPciAndIdeLimit(Disk diskInfo) {
Line 88: List<VmNetworkInterface> vmInterfaces =
getVmNetworkInterfaceDao().getAllForVm(getVmId());
--
To view, visit http://gerrit.ovirt.org/9724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
