ofri masad has posted comments on this change.
Change subject: webadmin: Add empty quota validator to update-VM
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1838: getOSType().ValidateSelectedItem(new NotEmptyValidation[] {
new NotEmptyValidation() });
Line 1839:
Line 1840: storage_pool dataCenter = (storage_pool)
getDataCenter().getSelectedItem();
Line 1841: if (dataCenter != null &&
dataCenter.getQuotaEnforcementType() ==
QuotaEnforcementTypeEnum.HARD_ENFORCEMENT) {
Line 1842: getQuota().ValidateSelectedItem(new IValidation[] { new
NotEmptyQuotaValidation() });
the name NotEmptyValidation is actually misleading - NotEmptyValidation only
applies to EntityModel holding String. The EntityModel returned by getQuota()
holds Quota.
Extending NotEmptyValidation is also not true - due to the same reason.
Line 1843: }
Line 1844:
Line 1845: getTotalCPUCores().ValidateEntity(new IValidation[] {
Line 1846: new NotEmptyValidation(),
--
To view, visit http://gerrit.ovirt.org/9694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2981ab55a30e2417d545cfe3bb63f777b2aa2798
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
