Moti Asayag has posted comments on this change.
Change subject: restapi: #868626 - All-Content Header
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
Line 248: getValidator(validatedClass).validateEnums(instance);
Line 249: }
Line 250:
Line 251: /**
Line 252: * @return true if request header contains [Populate='true']
shouldn't it be: contains [All-Content='true'] ?
Line 253: */
Line 254: protected boolean isPopulate() {
Line 255: List<String> populates =
httpHeaders.getRequestHeader(POPULATE);
Line 256: if (populates != null && populates.size() > 0) {
....................................................
Commit Message
Line 3: AuthorDate: 2012-11-05 10:26:06 +0200
Line 4: Commit: Ori Liel <ol...@redhat.com>
Line 5: CommitDate: 2012-11-05 10:33:17 +0200
Line 6:
Line 7: restapi: #868626 - All-Content Header
Please move the bug from the subject to the body as described on
config/engine-commit-template.txt
see for example: http://gerrit.ovirt.org/#/c/9573/
Line 8:
Line 9: Added header 'All-Content' (values: 'true'/'false') that states whether
the entity fetched
Line 10: should contain all possible information, or only the basice
inforamtion (which is most of
Line 11: the information, but there's still a difference). For example, for
VMs, supplying All-Content:false
Line 6:
Line 7: restapi: #868626 - All-Content Header
Line 8:
Line 9: Added header 'All-Content' (values: 'true'/'false') that states whether
the entity fetched
Line 10: should contain all possible information, or only the basice
inforamtion (which is most of
s/basice inforamtion/basic information
Line 11: the information, but there's still a difference). For example, for
VMs, supplying All-Content:false
Line 12: or not supplying All-Content header at all, will result in VM being
fetched without payload
Line 13: and ballooning information.
Line 14:
Line 11: the information, but there's still a difference). For example, for
VMs, supplying All-Content:false
Line 12: or not supplying All-Content header at all, will result in VM being
fetched without payload
Line 13: and ballooning information.
Line 14:
Line 15: This behavior is for GET requests, Create (POST) and Update (PUT) will
always return the full
Could you break this line after the first comma just to clarify POST and PUT
are behave differently than GET.
Line 16: entity.
Line 17:
Line 18: https://bugzilla.redhat.com/868626
Line 19:
--
To view, visit http://gerrit.ovirt.org/9018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ecfe2f374599eafecf9c683038b3eacfd4bca50
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
