Maor Lipchuk has posted comments on this change. Change subject: core: ImportVm test cleanup: make constant static ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java Line 68: v.setDiskSize(2); Line 69: return v; Line 70: } Line 71: Line 72: private static final String string100 = "0987654321" + I would also consider changing the parameter name to stringLengthOf100Characters or something like that, took me a precious second to realize that this funny parameter is actually 100 characters long Line 73: "0987654321" + Line 74: "0987654321" + Line 75: "0987654321" + Line 76: "0987654321" + -- To view, visit http://gerrit.ovirt.org/9619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
