Alissa Bonas has posted comments on this change.
Change subject: Reinitialize DC doesn't connect all hosts to the new
master(#880180)
......................................................................
Patch Set 2: (1 inline comment)
pls see my question regarding hardcoded returning true one line method..thanks
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 203: * @return
Line 204: */
Line 205: protected boolean performConnectOperations(VDS vds) {
Line 206: return true;
Line 207: }
Hi,
what is the purpose of creating a method that always returns true regardless of
its input param vds that is never evaluated nor used?
Line 208:
Line 209: private void connectAndRefreshAllUpHosts(final boolean
commandSucceeded) {
Line 210: for (VDS vds : getAllRunningVdssInPool()) {
Line 211: try {
--
To view, visit http://gerrit.ovirt.org/9748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3733b732b37f3a687b24f90bfdb1799757434d75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
