Michael Kublin has posted comments on this change. Change subject: Reinitialize DC doesn't connect all hosts to the new master(#880180) ......................................................................
Patch Set 2: I would prefer that you didn't submit this Perform a full override for method connectAndRefreshAllUpHosts at RecoveryStoragePoolCommand, no reason to use a common code, the Reconstruct flow and Recovery flow has a lot of differences at that method. 1. if condition 2. exception handler 3. check isInactive() not relevant for reconstruct flow. By keeping a common connectAndRefreshAllUpHosts method for both classes you create additional space for bugs and not understandable code. A good example is for bugs, is a previous change at connectAndRefreshAllUpHosts which caused regression at recovery scenario -- To view, visit http://gerrit.ovirt.org/9748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3733b732b37f3a687b24f90bfdb1799757434d75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
