Maor Lipchuk has posted comments on this change. Change subject: core: ImportVm cleanup: fix modifiers ......................................................................
Patch Set 3: Looks good to me, approved Originally, log should be get from the commandBase and not declared in the importVMCommand. unfortunately since the class has static methods (With no good reason), we must use it, but would be nice if it will be re-factored in the future. -- To view, visit http://gerrit.ovirt.org/9613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5c3d14c575e4045101a9345b09ce7d630e0933e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
