Moti Asayag has posted comments on this change.

Change subject: webadmin: Setup Network- doesn't show the correct boot protocol.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
Commit Message
Line 3: AuthorDate: 2012-12-05 18:54:12 +0200
Line 4: Commit:     Alona Kaplan <alkap...@redhat.com>
Line 5: CommitDate: 2012-12-05 18:54:12 +0200
Line 6: 
Line 7: webadmin: Setup Network- doesn't show the correct boot protocol.
IIRC having ' in the commit subject will cause some error to jenkins.

please replace "doesn't" with "does not"
Line 8: 
Line 9: The fix in commit 30f20efd648a1329c996f5c12f31741038bdc0be caused 
another
Line 10: bug.
Line 11: The attach method is used not only for manually attaching but also in 
the


--
To view, visit http://gerrit.ovirt.org/9752
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40fe51b46f94bdfa27270c9e5dcd94074b881c03
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to