Maor Lipchuk has posted comments on this change. Change subject: core: ImportVm cleanup: extract VM.hasImages() ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 3: AuthorDate: 2012-12-03 10:20:36 +0200 Line 4: Commit: Allon Mureinik <amure...@redhat.com> Line 5: CommitDate: 2012-12-03 10:58:57 +0200 Line 6: Line 7: core: ImportVm cleanup: extract VM.hasImages() Consider removing the colon here Line 8: Line 9: Added the helper method hasImages() to the VM class, instead of having Line 10: to implement it in the ImportVmCommand. Line 11: -- To view, visit http://gerrit.ovirt.org/9657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7486e68268700bd0c55204dce6fb3f711425f931 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
