Roy Golan has posted comments on this change.
Change subject: core: remove unmanaged devices on down VM event
......................................................................
Patch Set 2: Verified
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 454: if (vmBase.getos().isLinux() &&
vmBase.getusb_policy().equals(UsbPolicy.ENABLED_LEGACY)) {
Line 455: vmBase.setusb_policy(UsbPolicy.DISABLED);
Line 456: }
Line 457: }
Line 458:
this method have been moved from StopVmCommand and slightly adapted
Line 459: /**
Line 460: * remove VMs unmanaged devices that are created during run-once
or stateless run.
Line 461: * @param vmId
Line 462: */
Line 477: }
Line 478: }
Line 479: }
Line 480: }
Line 481:
this method have been moved from StopVmCommand as is
Line 482: /**
Line 483: * This method checks if we are stopping a VM that was started by
run-once In such case we will may have 2 devices,
Line 484: * one managed and one unmanaged for CD or Floppy This is not
supported currently by libvirt that allows only one
Line 485: * CD/Floppy This code should be removed if libvirt will support
in future multiple CD/Floppy
--
To view, visit http://gerrit.ovirt.org/9756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6593b9cb36fecc87f9b9af574d61300d55d6ad62
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
