Maor Lipchuk has posted comments on this change. Change subject: core: ImportVm cleanup: saveDiskImageDynamic ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 3: AuthorDate: 2012-11-28 17:42:10 +0200 Line 4: Commit: Allon Mureinik <amure...@redhat.com> Line 5: CommitDate: 2012-12-03 10:58:57 +0200 Line 6: Line 7: core: ImportVm cleanup: saveDiskImageDynamic Maybe use: ImportVm cleanup, extract method to save disk. instead only the method name Line 8: Line 9: Extracted the saveDiskImageDynamic(DiskImage) method instead of multiple Line 10: blocks of the same code. Line 11: -- To view, visit http://gerrit.ovirt.org/9615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba9d746c239e627b0db403fa1e1028a775e0d2ab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
