Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-upgrade - check for free space before upgrade
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
A couple of minor typos in messages.
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 1106:
Line 1107: # Check available space in backup location
Line 1108: freeSpace = utils.getAvailableSpace(BACKUP_DIR)
Line 1109: if freeSpace < (engineSize * 0.95):
Line 1110: logging.error("Availble disk space at %s (%s) is lower then
the minimum requirments for database backup (%s)"
White space.
s/Availble/Available/
s/requirments/requirements/
Line 1111: % (BACKUP_DIR, freeSpace, engineSize))
Line 1112: print output_messages.ERR_EXP_NO_SPACE % (BACKUP_DIR,
freeSpace, engineSize)
Line 1113: raise Exception(output_messages.ERR_EXP_NO_SPACE %
(BACKUP_DIR, freeSpace, engineSize))
Line 1114:
--
To view, visit http://gerrit.ovirt.org/9744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90eae48aea70187dc88c79044a353089f69350a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
