Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: extract VM.hasImages()
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 487: addVmToDb();
Line 488: VM vm = getVm();
Line 489: // if there aren't any images- we can just perform the end
Line 490: // vm related ops
Line 491: if (!vm.hasImages()) {
I would already write !vm.getImages().isEmpty() in the condition instead all
these refactoring, but I guess this is a matter of style...
Line 492: endVmRelatedOps();
Line 493: } else {
Line 494: processImages();
Line 495: }
--
To view, visit http://gerrit.ovirt.org/9657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7486e68268700bd0c55204dce6fb3f711425f931
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
