Moti Asayag has posted comments on this change.

Change subject: webadmin: Add option to mark network as public
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
Line 106:                 getVLanTag().setIsChangable((Boolean) 
getHasVLanTag().getEntity() && (Boolean) value);
Line 107:                 getHasMtu().setIsChangable((Boolean) value && 
isMTUOverrideSupported());
Line 108:                 getMtu().setIsChangable((Boolean) 
getHasMtu().getEntity() && (Boolean) value
Line 109:                         && isMTUOverrideSupported());
Line 110:                 getPublicUse().setIsChangable((Boolean) value);
Done
Line 111:                 onIsEnableChange();
Line 112:             }
Line 113:         });
Line 114:         init();


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/NewNetworkPopupPresenterWidget.java
Line 13: 
Line 14:     @Inject
Line 15:     public NewNetworkPopupPresenterWidget(EventBus eventBus, ViewDef 
view) {
Line 16:         super(eventBus, view);
Line 17:     }
Done


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
Line 58:                }
Line 59: 
Line 60:                .publicUseEditor {
Line 61:                    padding: 0px;
Line 62:             width: 100%;
Done
Line 63:         }
Line 64: 
Line 65:        </ui:style>
Line 66: 


--
To view, visit http://gerrit.ovirt.org/9542
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib12cb6fc64a06d0305b59f74332c4e75bc05bfe8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to