Alissa Bonas has posted comments on this change.
Change subject: core: ImagesHandler.setDiskAlias early return
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 117:
Line 118: String vmName = "";
Line 119: int count = 1;
Line 120: if (vm != null) {
Line 121: vmName = vm.getvm_name();
If vm is null, and vmName remains "" - will the disk alias be correct?
And is there a point setting a disk alias if the vm is null?
Line 122: count = vm.getDiskMapCount() + 1;
Line 123: }
Line 124: disk.setDiskAlias(getSuggestedDiskAlias(disk, vmName, count));
Line 125: return true;
--
To view, visit http://gerrit.ovirt.org/9658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69cb7b17e97c86f14eaf64f751183bb5d1b0812a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
