Liron Aravot has posted comments on this change.
Change subject: CommandBase - persist command if the parent command has a
callback
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/41696/11/backend/manager/modules/bl
Liron Aravot has posted comments on this change.
Change subject: CommandBase - persist command if the parent command has a
callback
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/41696/9/backend/manager/modules/bll/
Liron Aravot has posted comments on this change.
Change subject: CommandBase - persist command if the parent command has a
callback
..
Patch Set 9:
@Ravi -
I do agree with your comment, but this is relevant for today as well (
Liron Aravot has posted comments on this change.
Change subject: core: CommandBase - adding noAsyncOperations()
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/41694/8/backend/manager/modules/bll/src/main/java/org/ovi
Liron Aravot has submitted this change and it was merged.
Change subject: CoCoAsyncTaskHelper: do not clear command if the parent has
callback
..
CoCoAsyncTaskHelper: do not clear command if the parent has callback
If the pare
Liron Aravot has posted comments on this change.
Change subject: CoCoAsyncTaskHelper: do not clear command if the parent has
callback
..
Patch Set 7: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/41687
T
Liron Aravot has posted comments on this change.
Change subject: engine: Add support for Refresh LUNs size
..
Patch Set 11:
(6 comments)
partial revoew
https://gerrit.ovirt.org/#/c/39318/11/backend/manager/modules/bll/src/mai
Liron Aravot has submitted this change and it was merged.
Change subject: core: handling domain status update
..
core: handling domain status update
this change handles:
1. changing domain status from PreparingToMaintenance to
Liron Aravot has posted comments on this change.
Change subject: core: handling domain status update
..
Patch Set 6: Verified+1 Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41686
To unsubscribe, visit https://gerri
Liron Aravot has posted comments on this change.
Change subject: core: CommandBase - obtain child commands on endAction()
..
Patch Set 6:
Well, I'm not sure if that's the callback place to know what to do with the
child comman
Liron Aravot has posted comments on this change.
Change subject: CoCoAsyncTaskHelper: do not clear command if the parent has
callback
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/41687/1/backend/manager/modules/b
Liron Aravot has posted comments on this change.
Change subject: VdcActionParametersBase - adding VdsRunningOn member
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41688/1/backend/manager/modules/common/src/main/jav
Liron Aravot has posted comments on this change.
Change subject: core: Remove unused imports in Cinder commands
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42316
To unsubscribe, visit https://gerri
Liron Aravot has submitted this change and it was merged.
Change subject: core: check hosts statuses to determine the data center status
..
core: check hosts statuses to determine the data center status
On data centers with SPM
Liron Aravot has posted comments on this change.
Change subject: core: check hosts statuses to determine the data center status
..
Patch Set 6: Verified+1 Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41685
To unsub
Liron Aravot has posted comments on this change.
Change subject: core: introduce DiskContentType
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39143
To unsubscribe, visit https://gerrit.ovirt.org/set
Liron Aravot has posted comments on this change.
Change subject: core: VdcActionParametersBase - choose if command is ended by
parent
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/41689/1/backend/manager/modules/c
Liron Aravot has posted comments on this change.
Change subject: core: CommandBase - avoid releasing lock if there is a callback
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/41692/1/backend/manager/modules/bll/src
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding DataCenterWithoutSpm config value
..
core: adding DataCenterWithoutSpm config value
Change-Id: I2dd88f249cd90f1cb7ef95a3f3bf8cf821921cf1
Sig
Liron Aravot has posted comments on this change.
Change subject: core: adding DataCenterWithoutSpm config value
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42097
To unsubscribe, visit ht
Liron Aravot has posted comments on this change.
Change subject: core: CommandBase - end job after execution only if there is no
callback
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41693/1/backend/manager/module
Liron Aravot has posted comments on this change.
Change subject: core: adding DataCenterWithoutSpm config value
..
Patch Set 1:
went over
--
To view, visit https://gerrit.ovirt.org/42097
To unsubscribe, visit https://gerrit.o
Liron Aravot has abandoned this change.
Change subject: core: OvfDataUpdater - removal of unused method
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/28934
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ger
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39471
To unsubscribe, visi
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/39471/7/backend/manager/modules/bll/src/ma
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 6: -Code-Review
--
To view, visit https://gerrit.ovirt.org/39471
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 6: Code-Review+2
(2 comments)
https://gerrit.ovirt.org/#/c/39471/6/backend/manager/mod
Liron Aravot has posted comments on this change.
Change subject: core: CommandBase - obtain child commands on endAction()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41690/1/backend/manager/modules/bll/src/main/ja
Liron Aravot has posted comments on this change.
Change subject: core: CommandBase - obtain child commands on endAction()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41690/1/backend/manager/modules/bll/src/main/ja
Liron Aravot has posted comments on this change.
Change subject: core: CommandBase - obtain child commands on endAction()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41690/1/backend/manager/modules/bll/src/main/ja
Liron Aravot has posted comments on this change.
Change subject: core: CommandBase - avoid inserting placeholders for dc without
spm
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41691/1/backend/manager/modules/bll
Liron Aravot has posted comments on this change.
Change subject: CommandBase - persist command if the parent command has a
callback
..
Patch Set 1:
We don't always need to execute using CoCo in a different thread and wait on a
Liron Aravot has posted comments on this change.
Change subject: squash removentireimage
..
Patch Set 1:
asd
--
To view, visit https://gerrit.ovirt.org/41012
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mes
Liron Aravot has posted comments on this change.
Change subject: core: introduce DiskContentType
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39143
To unsubscribe, visit https://gerrit.ovirt.org/set
Liron Aravot has posted comments on this change.
Change subject: core: introduce DiskContentType
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/39143/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/c
Liron Aravot has posted comments on this change.
Change subject: core: make EventQueue a CDI Singleton, dump jndi
..
Patch Set 6: Code-Review+1
(3 comments)
https://gerrit.ovirt.org/#/c/40642/6//COMMIT_MSG
Commit Message:
Lin
Liron Aravot has posted comments on this change.
Change subject: vdsbroker: async vdscommand
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/40565/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/cor
Liron Aravot has posted comments on this change.
Change subject: engine : Add json rpc request completed method
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/39373/8/backend/manager/modules/vdsbroker/src/main/java/
Liron Aravot has posted comments on this change.
Change subject: vdsbroker: async vdscommand
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/40565/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/co
Liron Aravot has posted comments on this change.
Change subject: engine : Add json rpc request completed method
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/39373/8/backend/manager/modules/vdsbroker/src/main/java/
Liron Aravot has posted comments on this change.
Change subject: engine : Add json rpc request completed method
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39373/3/backend/manager/modules/vdsbroker/src/main/java/o
Liron Aravot has submitted this change and it was merged.
Change subject: core: encapsulate isLastMaster logic
..
core: encapsulate isLastMaster logic
Change-Id: I1cbbf89d26c8c4e8f90e68bb89472bb4a6ee4518
Signed-off-by: Federico
Liron Aravot has submitted this change and it was merged.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
core: move getNewMaster to ReconstructMasterDomain
Change-Id: I30d342a4c5802cdfbf2c78b50dad4c797c13
Liron Aravot has posted comments on this change.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
Patch Set 17: Verified+1
--
To view, visit https://gerrit.ovirt.org/28444
To unsubscribe, visit https://ger
Liron Aravot has posted comments on this change.
Change subject: engine: Add support for Refresh LUNs size
..
Patch Set 8:
(20 comments)
https://gerrit.ovirt.org/#/c/39318/8/backend/manager/modules/bll/src/main/java/org/ovirt/
Liron Aravot has posted comments on this change.
Change subject: engine : Add json rpc request completed method
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39373/3/backend/manager/modules/vdsbroker/src/main/java/o
Liron Aravot has posted comments on this change.
Change subject: engine : Add json rpc request completed method
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39373/3/backend/manager/modules/vdsbroker/src/main/java/o
Liron Aravot has posted comments on this change.
Change subject: engine : Add json rpc request completed method
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/39373/3/backend/manager/modules/vdsbroker/s
Liron Aravot has posted comments on this change.
Change subject: wip, engine : Remove Disk command using getVolumeInfo
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/39374/4/backend/manager/modules/bll/src/main/java/
Liron Aravot has posted comments on this change.
Change subject: core: encapsulate isLastMaster logic
..
Patch Set 18: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/28445/18/backend/manager/modules/bll/src/main/java/o
Liron Aravot has posted comments on this change.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
Patch Set 17: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/28444
To unsubscribe, visit https://
Liron Aravot has posted comments on this change.
Change subject: core: Check attached VMs snapshot status when moving a disk
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/40080/4/backend/manager/modules/bll/src/mai
Liron Aravot has posted comments on this change.
Change subject: core: Check attached VMs snapshot status when moving a disk
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40080/3/backend/manager/modules/bll/src/main
Liron Aravot has posted comments on this change.
Change subject: core: Add the Data Center version in the log
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40050
To unsubscribe, visit https://gerrit.
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 25: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37664
To unsubscribe, visit ht
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 21: Code-Review+1
(1 comment)
Backend looks good, just need review for
https://gerrit.ovir
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/37664/20/backend/manager/modules/restapi/types
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 19:
(2 comments)
one left gap here, this property should be added to the ovf generated for
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 3:
@Arik, I don't agree. first of all, the locking manager resides on utils, not
on bl
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39471/3/backend/manager/modules/vdsbroker/
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 3:
@Arik
first, i'm happy that we agreed on this change.
second, i don't agree - the l
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/37664/15/packaging/dbscripts/upgrade/03_06_117
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 3:
@Arik,
The lock is taken per VM (by it's id), we don't need a mutex here as concurre
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/39471/2/backend/manager/modules/vdsbroker
Liron Aravot has posted comments on this change.
Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39471/2/backend/manager/modules/vdsbroker/
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 17:
(2 comments)
https://gerrit.ovirt.org/#/c/37664/17/backend/manager/modules/bll/src/main
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/37664/15/packaging/dbscripts/upgrade/03_06_117
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 15:
(20 comments)
https://gerrit.ovirt.org/#/c/37664/15/backend/manager/modules/bll/src/mai
Liron Aravot has uploaded a new change for review.
Change subject: tmp
..
tmp
Change-Id: I5b5bb672c5027c262619691007593a16875024aa
Signed-off-by: lara...@redhat.com
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/eng
Liron Aravot has posted comments on this change.
Change subject: core: Requesting to consume quota while extending a disk fix.
..
Patch Set 3: Code-Review+2
my comments were fixed in a following patch.
--
To view, visit https
Liron Aravot has posted comments on this change.
Change subject: core: Requesting to consume quota while extending a disk fix.
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/39330/3/backend/manager/modules/bll/src/m
Liron Aravot has posted comments on this change.
Change subject: core: Requesting to consume quota while extending a disk fix.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39330/2/backend/manager/modules/bll/src/ma
Liron Aravot has posted comments on this change.
Change subject: core: Requesting to consume quota while extending a disk fix.
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/39330/2/backend/manager/modules/bll/src/m
Liron Aravot has abandoned this change.
Change subject: tmp4
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/39323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id:
Liron Aravot has uploaded a new change for review.
Change subject: tmp2
..
tmp2
Change-Id: I85ddaf7abb736d6298be7f5e358d52cf2e5a48cb
Signed-off-by: lara...@redhat.com
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/e
Liron Aravot has abandoned this change.
Change subject: tmp2
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/39210
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id:
Liron Aravot has uploaded a new change for review.
Change subject: tmp4
..
tmp4
Change-Id: Ia0bfedbec4f181afdab91801c2abecde3fb2206e
Signed-off-by: lara...@redhat.com
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/e
Liron Aravot has posted comments on this change.
Change subject: core: introduce DiskContentType
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/39143/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/c
Liron Aravot has abandoned this change.
Change subject: tmp
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/39206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I
Liron Aravot has abandoned this change.
Change subject: tmp
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/39205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I
Liron Aravot has uploaded a new change for review.
Change subject: tmp
..
tmp
Change-Id: I71ae74034468d6a7a6c9647ef9d72f51a5f13a0b
Signed-off-by: lara...@redhat.com
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/eng
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/37664/8/backend/manager/modules/bll/src/main/j
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/37664/9/backend/manager/modules/bll/src/main/j
Liron Aravot has abandoned this change.
Change subject: tmp
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/38435
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I
Liron Aravot has restored this change.
Change subject: tmp
..
Restored
--
To view, visit https://gerrit.ovirt.org/38435
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: restore
Gerrit-Change-Id: I64
Liron Aravot has posted comments on this change.
Change subject: core: Prevent VM migration when SCSI reservation is used
..
Patch Set 8:
(12 comments)
https://gerrit.ovirt.org/#/c/37664/8/backend/manager/modules/bll/src/main/
Liron Aravot has posted comments on this change.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/28444/16/backend/manager/modules/bll/src/main/java/o
Liron Aravot has posted comments on this change.
Change subject: core: End VM export gracefully upon failure in updating OVF
..
Patch Set 1:
Tal, i'm totally sure what is preferred here.
It's very rare that under normal circums
Liron Aravot has abandoned this change.
Change subject: tmp
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/38435
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I
Liron Aravot has abandoned this change.
Change subject: core: determine whether domain monitoring result is actual
..
Abandoned
This patch shouldn't be backported for the 3.5.2 branch according to the BZ
target release, abando
Liron Aravot has posted comments on this change.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/28444/15/backend/manager/modules/bll/src/main/java/o
Liron Aravot has posted comments on this change.
Change subject: core: encapsulate isLastMaster logic
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/28445
To unsubscribe, visit https://gerrit.ovirt.o
Liron Aravot has posted comments on this change.
Change subject: core: determine whether domain monitoring result is actual
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38842
To unsubscribe, visit http
Liron Aravot has uploaded a new change for review.
Change subject: core: determine whether domain monitoring result is actual
..
core: determine whether domain monitoring result is actual
When the domain monitoring results are r
Liron Aravot has posted comments on this change.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/28444/12/backend/manager/modules/bll/src/main/java/o
Liron Aravot has posted comments on this change.
Change subject: core: determine whether domain monitoring result is actual
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38640
To unsubscribe, visit http
Liron Aravot has posted comments on this change.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/28444/12/backend/manager/modules/bll/src/main/java/
Liron Aravot has posted comments on this change.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/28444/12/backend/manager/modules/bll/src/main/java/o
Liron Aravot has posted comments on this change.
Change subject: core: encapsulate isLastMaster logic
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/28445/13/backend/manager/modules/bll/src/main/java/org/ovirt/engin
Liron Aravot has posted comments on this change.
Change subject: core: determine whether domain monitoring result is actual
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38640/1/packaging/dbscripts/upgrade/pre_upgra
1 - 100 of 2965 matches
Mail list logo