Liron Aravot has posted comments on this change. Change subject: core: encapsulate isLastMaster logic ......................................................................
Patch Set 18: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/28445/18/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java: Line 40: Line 41: protected StorageDomain newMasterStorageDomain; Line 42: protected Guid newMasterStorageDomainId; Line 43: Line 44: protected boolean isLastMaster; please change to private when you rebase Line 45: Line 46: /** Line 47: * Constructor for command creation when compensation is applied on startup Line 48: * -- To view, visit https://gerrit.ovirt.org/28445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbbf89d26c8c4e8f90e68bb89472bb4a6ee4518 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
