Liron Aravot has posted comments on this change. Change subject: core: introduce DiskContentType ......................................................................
Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/39143/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java: Line 75: public void setLogicalName(String logicalName) { Line 76: this.logicalName = logicalName; Line 77: } Line 78: Line 79: public abstract long getSize(); did you leave it out of the hashCode/equals methods intentionally? Line 80: Line 81: @Override Line 82: public int hashCode() { Line 83: final int prime = 31; Line 130: @JsonIgnore Line 131: public boolean isDiskSnapshot() { Line 132: return false; Line 133: } Line 134: you should add here @JsonIgnore Line 135: public boolean isOvfStore() { Line 136: return contentType == DiskContentType.OVF_STORE; Line 137: } Line 138: -- To view, visit https://gerrit.ovirt.org/39143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I410a346cf0be32a99e10e503c26eb29b3688e748 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
