Liron Aravot has posted comments on this change. Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks ......................................................................
Patch Set 3: @Arik, I don't agree. first of all, the locking manager resides on utils, not on bll and is already used not only by commands. I'm not realy in favour with Roy proposal, while practically it should be fine i do find it logically problematic - why would you want to block the vm monitoring when looking for a address? We do need some infrawhether it's the lock manager or something else. What if tomorrow we'd want to lock a domain, we'll need add a new class for domain locking? and another one for disks? If we don't want to use the lock manager, we need a different infrastructure that'll handle that scenarios rather the reimplement it for any usecase. the locking manager is a the only locking infrastrcture at the moment, so i don't see a reason to not use it. I'll answer also inline to your comment - 1. you can correlate id of whatever entity you want to lock this is exactly what is needed in this case, a lock to vm by id. 2. you can add error message adding a message can also relevant for any taken lock, if it's taken it's provide info on why it is. 3. you can add scope the scope is something used by commands to know when to release the lock on the lock manage (the lock manager isn't aware to it). 4. it is a wrapper for multiple shared/exclusive locks this is relevant for any other usecase. 6. it is integrated in the command's framework The fact that commands use the lock manager doesn't mean that it shouldn't be used by other parts of the system. -- To view, visit https://gerrit.ovirt.org/39471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e621618e8891fca52b48bff437cc4c2a1f695db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
