Liron Aravot has posted comments on this change. Change subject: engine : Add json rpc request completed method ......................................................................
Patch Set 8: (3 comments) https://gerrit.ovirt.org/#/c/39373/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StatusReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StatusReturnForXmlRpc.java: Line 22: return true; Line 23: } Line 24: Line 25: public StatusForXmlRpc getXmlRpcStatus() { Line 26: if (mStatus == null) { do we still need the mStatus member? Line 27: Map<String, Object> statusMap = (Map<String, Object>) innerMap.get(STATUS); Line 28: mStatus = new StatusForXmlRpc(statusMap); Line 29: } Line 30: return mStatus; Line 23: } Line 24: Line 25: public StatusForXmlRpc getXmlRpcStatus() { Line 26: if (mStatus == null) { Line 27: Map<String, Object> statusMap = (Map<String, Object>) innerMap.get(STATUS); if the request is cancelled I believe that you'll get here NPE - what was the previous behavior on that? Line 28: mStatus = new StatusForXmlRpc(statusMap); Line 29: } Line 30: return mStatus; Line 31: } Line 35: } Line 36: Line 37: @Override Line 38: public String toString() { Line 39: return getClass().getSimpleName() + " [mStatus=" + (isRequestCompleted() ? getXmlRpcStatus() : "N/A") + "]"; please change N/A to something clearer (pending for response or something like that) Line 40: } -- To view, visit https://gerrit.ovirt.org/39373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e0ef961927c3fb17656ecac12d245c25b2ee367 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
