Liron Aravot has posted comments on this change. Change subject: core: CommandBase - adding noAsyncOperations() ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/41694/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1752: } Line 1753: Line 1754: protected boolean noAsyncOperations() { Line 1755: return !hasTasks() && getCallBack() == null; Line 1756: } > should also check: !(this instanceof IVdsAsyncCommand) As this check appears only once in the CommandBase, whether it's correct or not - I'd like to leave this out of this change. This method is intended to replace the hasTasks() calls. we can later examine whether the IVdsAsyncCommand check is relevant for all of the places and if it is to add it. Line 1757: Line 1758: protected void startPollingAsyncTasks() { Line 1759: startPollingAsyncTasks(getReturnValue().getVdsmTaskIdList()); Line 1760: } -- To view, visit https://gerrit.ovirt.org/41694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02e6794f0ebeebcb652cea823bb5061c9ccb2844 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
