Liron Aravot has posted comments on this change. Change subject: core: Prevent VM migration when SCSI reservation is used ......................................................................
Patch Set 17: (2 comments) https://gerrit.ovirt.org/#/c/37664/17/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java: Line 233: for (VM vm : vms) { Line 234: List<VmDevice> devices = getDbFacade().getVmDeviceDao().getVmDeviceByVmIdAndType(vm.getId(), VmDeviceGeneralType.DISK); Line 235: for (VmDevice device : devices) { Line 236: if (device.getIsPlugged() && device.isUsingScsiReservation()) { Line 237: vmUsingScsiReservation.append(vm.getName()).append(" "); that should be done bit differently using a list that store the names and join() in the end with a comma as a separator - please do that this way. as there are other methods here that return message for first violating vm I don't mind if you keep the old version and we'll change it in a further patch. Line 238: } Line 239: } Line 240: } Line 241: https://gerrit.ovirt.org/#/c/37664/17/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 508: @DefaultStringValue("Cannot ${action} ${type}. VM is pinned to Host.") Line 509: String ACTION_TYPE_FAILED_VM_IS_PINNED_TO_HOST(); Line 510: Line 511: @DefaultStringValue("Cannot ${action} ${type}. VM uses SCSI reservation.") Line 512: String ACTION_TYPE_FAILED_VM_USES_SCSI_RESERVATION(); you added four values here, while 3 here https://gerrit.ovirt.org/#/c/37664/17/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java and 2 here- https://gerrit.ovirt.org/#/c/37664/17/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties please align those across the messages files. Line 513: Line 514: @DefaultStringValue("Cannot ${action} ${type}. SCSI reservation can be set only when SGIO is unfiltered.") Line 515: String ACTION_TYPE_FAILED_SGIO_IS_FILTERED(); Line 516: -- To view, visit https://gerrit.ovirt.org/37664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia38c03dae04c9dbb30c882941391b1909f5af416 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
