Liron Aravot has posted comments on this change. Change subject: core: encapsulate isLastMaster logic ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/28445/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java: Line 333: * In case of master domain this method decide if to move master to other domain or move pool to maintenance (since Line 334: * there is no master domain) Line 335: * Line 336: * @param newMaster The selected new master domain Line 337: * @param lockNewMaster If true the new master domain will be locked can you fix it by adding what is returned now from this function? Line 338: */ Line 339: protected boolean proceedStorageDomainTreatmentByDomainType(final StorageDomain newMaster, Line 340: final boolean lockNewMaster) { Line 341: if (newMaster == null) { -- To view, visit https://gerrit.ovirt.org/28445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbbf89d26c8c4e8f90e68bb89472bb4a6ee4518 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
