Liron Aravot has posted comments on this change. Change subject: core: Check attached VMs snapshot status when moving a disk ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40080/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java: Line 187: for (Pair<VM, VmDevice> pair : getVmsWithVmDeviceInfoForDiskId()) { Line 188: VM vm = pair.getFirst(); Line 189: if (!validate(snapshotsValidator.vmNotInPreview(vm.getId())) Line 190: || !validate(snapshotsValidator.vmNotDuringSnapshot(vm.getId()))) { Line 191: return false; we should check only the vm the active volume is attached to and not vms that a snapshot of the disk is attached to. in case that the disk snapshot is attached to other vm that is down, we shouldn't care if that vm is in preview (for example). Line 192: } Line 193: } Line 194: return true; Line 195: } -- To view, visit https://gerrit.ovirt.org/40080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
