Liron Aravot has posted comments on this change. Change subject: wip, engine : Remove Disk command using getVolumeInfo ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39374/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommandCallback.java: Line 13: import java.util.List; Line 14: Line 15: public class RemoveImageCommandCallback extends CommandCallback { Line 16: Line 17: private OneImageInfoReturnForXmlRpc imageInfoReturn; question - how do we guarantee synchronization on the object between the different threads executing the callback? Line 18: private IrsProxyData irsProxyData; Line 19: Line 20: @Override Line 21: public void doPolling(Guid cmdId, List<Guid> childCmdIds) { -- To view, visit https://gerrit.ovirt.org/39374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I458143387f89a5d55bda5f1d4f9d44be4f7fb197 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
