Liron Aravot has posted comments on this change. Change subject: core: End VM export gracefully upon failure in updating OVF ......................................................................
Patch Set 1: Tal, i'm totally sure what is preferred here. It's very rare that under normal circumstances an export would fail on the ovf upload phase - the scenario described in the bug is caused by a "broken" export domain and maybe that's something we need to fix regardless (better export domain monitoring). My first instinct is toward just leaving the situation as is (if export fails on that, it's better to keep retrying or to check what is wrong). If you want to revert on that case it's also fine by me, but i'm not 100% sure about that. Allon - yes, we would use coco for that on 3.6. -- To view, visit https://gerrit.ovirt.org/37583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefa719e8872a69de5b3d3fa79758e12e7b63f80f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
