Liron Aravot has posted comments on this change. Change subject: core: move getNewMaster to ReconstructMasterDomain ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/28444/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java: Line 69: protected LockProperties applyLockProperties(LockProperties lockProperties) { Line 70: return lockProperties; Line 71: } Line 72: Line 73: protected StorageDomain getNewMaster() { > electNewMaster is executed only once even now. This is just as the old code if it returns as null it'll be executed multiple times, as this is already the current situation it's fine by me Line 74: if (newMaster == null) { Line 75: newMaster = electNewMaster(true, canChooseInactiveDomainAsMaster, canChooseCurrentMasterAsNewMaster); Line 76: } Line 77: return newMaster; -- To view, visit https://gerrit.ovirt.org/28444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30d342a4c5802cdfbf2c78b50dad4c797c137fe2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
