Liron Aravot has posted comments on this change. Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/39471/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java: Line 111: return drive; Line 112: } Line 113: Line 114: private void addAddress(Map<String, Object> map, String address) { Line 115: lockVmWithWait(); i'd reduce the scope here to the relevant part only, not the the whole method Line 116: if (getParameters().getDisk().getDiskInterface() != DiskInterface.VirtIO_SCSI && Line 117: getParameters().getDisk().getDiskInterface() != DiskInterface.SPAPR_VSCSI) { Line 118: if (StringUtils.isNotBlank(address)) { Line 119: map.put("address", XmlRpcStringUtils.string2Map(address)); Line 136: Line 137: addAddressForScsiDisk(map, address, vmDeviceUnitMap, sPaprVscsiIndex, true); Line 138: } Line 139: } Line 140: LockManagerFactory.getLockManager().releaseLock(vmLock); > i think it would be safer to put this in finally +1 Line 141: } Line 142: Line 143: private void addAddressForScsiDisk(Map<String, Object> map, Line 144: String address, -- To view, visit https://gerrit.ovirt.org/39471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e621618e8891fca52b48bff437cc4c2a1f695db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
