Liron Aravot has posted comments on this change. Change subject: vdsbroker: async vdscommand ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/40565/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java: Line 69: @Override Line 70: public Object process(Object returnValue, VDSAsyncReturnValue value) { Line 71: DiskImage di = null; Line 72: try { Line 73: proceedProxyReturnValue(); > We plan to remove this file from this patch, and post it in the sample file I'll rephrase - the execute() method contains handling to the different failures raised by proceedProxyReturnValue(); as now we'll fail only 'asynchronously' after proceedProxyReturnValue() is executed - this handling will never run, leading to different results for async/sync execution. so in order to use that infrastructure, a lot of changes needs to be done in the infrastructure of the VDSCommand base classes. Line 74: di = buildImageEntity((Map<String, Object>) returnValue); Line 75: } catch (Exception e) { Line 76: printReturnValue(); Line 77: } finally { -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
