Liron Aravot has posted comments on this change. Change subject: core: CommandBase - avoid inserting placeholders for dc without spm ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41691/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1410: * This method is called before executeAction to insert the async task Line 1411: * placeholders for the child commands. Line 1412: */ Line 1413: protected void insertAsyncTaskPlaceHolders() { Line 1414: if (getStoragePool() != null && !isDataCenterWithSpm()) { > 1. there is no implementation of isDataCenterWithSpm() in this patch. 1. I'll reorder the patches so the implementation will be present. 2. It seems like the command base is already aware of async tasks (which we move out from and also aren't related to this class) - as this code goes for deletion anyway on 4.0 if not earlier (i can't recall if this is already removed on the latest master) i wouldn't spend time on refactoring that. Line 1415: return; Line 1416: } Line 1417: Line 1418: TransactionSupport.executeInScope(TransactionScopeOption.Required, -- To view, visit https://gerrit.ovirt.org/41691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If764d57a46e712aa4c6eb9f50a3d6699d27c89a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
