Liron Aravot has posted comments on this change. Change subject: engine : Add json rpc request completed method ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39373/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java: Line 40: getParameters().getImageId().toString()); Line 41: DiskImage di = null; Line 42: try { Line 43: proceedProxyReturnValue(); Line 44: di = buildImageEntity(imageInfoReturn.getInfo()); > Liron - this patch is in order to introduce the concept, and not to apply i Oved, I'll try to elaborate more. In the current implementation, each caller needs to know what to do with the response when it arrives- opposed to today in which the vds command encapsulates that and returns the complete answer. for example, in this command the caller get's an image entity. It makes more sense to me that the caller won't have to "build" the output by himself..but that the command will do that and the caller will get a "complete" response once the execution has finished, same as today. Line 45: } catch (Exception e) { Line 46: printReturnValue(); Line 47: // nothing to do - logging inside upper functions Line 48: } finally { -- To view, visit https://gerrit.ovirt.org/39373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e0ef961927c3fb17656ecac12d245c25b2ee367 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
