Liron Aravot has posted comments on this change. Change subject: core: move getNewMaster to ReconstructMasterDomain ......................................................................
Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/28444/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java: Line 43: protected Guid newMasterStorageDomainId = Guid.Empty; Line 44: Line 45: protected boolean canChooseInactiveDomainAsMaster; Line 46: Line 47: protected boolean canChooseCurrentMasterAsNewMaster; we can eliminate canChooseInactiveDomainAsMaster/canChooseCurrentMasterAsNewMaster they are used only once. Line 48: Line 49: /** Line 50: * Constructor for command creation when compensation is applied on startup Line 51: * Line 116: } Line 117: Line 118: protected boolean reconstructMaster() { Line 119: newMasterStorageDomainId = getNewMasterId(); Line 120: proceedStorageDomainTreatmentByDomainType(getNewMaster(), false); why aren't you using newMasterStorageDomainId? (or removing newMasterStorageDomainId) Line 121: Line 122: // To issue a reconstructMaster you need to set the domain inactive unless the selected domain is the current master Line 123: if (getParameters().isInactive() && !getStorageDomain().getId().equals(getNewMasterId())) { Line 124: executeInNewTransaction(new TransactionMethod<Void>() { -- To view, visit https://gerrit.ovirt.org/28444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30d342a4c5802cdfbf2c78b50dad4c797c137fe2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
