Yair Zaslavsky has uploaded a new change for review.
Change subject: DO NOT SUBMIT core: Introducing new method in DiskImageDAO
..
DO NOT SUBMIT core: Introducing new method in DiskImageDAO
This patch introduces a new sp + metho
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fixing images_storage_domain_view
..
core: Fixing images_storage_domain_view
When performing join between images and
vm_devices the join should be on
vm_
Yair Zaslavsky has posted comments on this change.
Change subject: DO NOT SUBMIT core: New mechanism in CommandBase (rollback
using command)
..
Patch Set 1: (2 inline comments)
.
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Improve exception handling in end actions
..
core: Improve exception handling in end actions
The end action didn't handle exceptions well, always
Mike Kolesnik has posted comments on this change.
Change subject: core: Improve exception handling in end actions
..
Patch Set 2: Verified; Looks good to me, approved
Added comment as yzaslavs asked & acked for merge
--
To vie
Mike Kolesnik has posted comments on this change.
Change subject: core: Improve exception handling in end actions
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Allon Mureinik has posted comments on this change.
Change subject: engine-core: [autorecovery] Autorecovery logic
..
Patch Set 11: Looks good to me, but someone else must approve
Agree with all of Laszlo's answers.
--
To view,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Improve exception handling in end actions
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
just add the minor comment and merge.
..
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Improve exception handling in end actions
..
core: Improve exception handling in end actions
The end action didn't handle exceptions well, always trying t
Moti Asayag has posted comments on this change.
Change subject: core: getting disk of vm and templates differently
..
--
To view, visit http://gerrit.ovirt.org/2416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Moti Asayag has posted comments on this change.
Change subject: core: move interfaces and disks collections to VMBase
..
Patch Set 1: (1 inline comment)
File
backend/manager
Eli Mesika has uploaded a new change for review.
Change subject: core: fixes to vm_device upgrade script patch
..
core: fixes to vm_device upgrade script patch
Can noy be done on source due to script numbering change patch
Chan
Moti Asayag has posted comments on this change.
Change subject: core: remove unmanaged devices when a stateless VM is stopped
..
Patch Set 1: (1 inline comment)
File
backend
Moti Asayag has posted comments on this change.
Change subject: core: Update VM devices on DB when hash changes
..
Patch Set 1: (4 inline comments)
File
backend/manager/modu
Ayal Baron has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2271
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateStoragePoolCommand
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/m
Eli Mesika has posted comments on this change.
Change subject: core: getting disk of vm and templates diffrently
..
Patch Set 1: (4 inline comments)
File
backend/manager/mod
Eli Mesika has posted comments on this change.
Change subject: core: Handle monitor special parameters
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/sr
Eli Mesika has posted comments on this change.
Change subject: core: move interfaces and disks collections to VMBase
..
Patch Set 1: (4 inline comments)
File
backend/manager
Eli Mesika has posted comments on this change.
Change subject: core: Add OVF Resource type to oVirt device type mapping
..
Patch Set 1: (3 inline comments)
File
backend/mana
Moti Asayag has posted comments on this change.
Change subject: core: add helper methods to VmDeviceCommonUtils.
..
Patch Set 1: (1 inline comment)
File
backend/manager/modu
Eli Mesika has posted comments on this change.
Change subject: core: remove unmanaged devices when a stateless VM is stopped
..
Patch Set 1: (1 inline comment)
File
backend/
Eli Mesika has posted comments on this change.
Change subject: core: Update VM devices on DB when hash changes
..
Patch Set 1: (2 inline comments)
File
backend/manager/modul
Maor Lipchuk has posted comments on this change.
Change subject: Refactor UpdateStoragePoolCommand
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/ma
Maor Lipchuk has posted comments on this change.
Change subject: Run upgradeStoragePool on cluster compatibility change
..
Patch Set 1: (1 inline comment)
Please remove UpdateStoragePoolCommand.java.orig from the patch set.
..
Eli Mesika has posted comments on this change.
Change subject: core: Update VM devices on DB when hash changes
..
Patch Set 1: (15 inline comments)
File
backend/manager/modu
Eyal Edri has posted comments on this change.
Change subject: gwt: Removal of SharedGwt module
..
Patch Set 2: Verified
verified in jenkins with: maven 3.0.3
mvn clean install -Pgwt-user,gwt-admin
--
To view, visit http://gerr
Moti Asayag has posted comments on this change.
Change subject: core: Adding method to get the ISO domain of a data center
..
Patch Set 1: (1 inline comment)
File
backend/ma
Eli Mesika has posted comments on this change.
Change subject: core: seperating code to enable working with cluster 3.0 and 3.1
..
Patch Set 1: (6 inline comments)
File
back
Daniel Erez has posted comments on this change.
Change subject: frontend: Add Quota validation message to AppErrors
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2388
To unsubscr
ovirt_engine_gwt_admin - Build # 31 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/31/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/
Saggi Mizrahi has uploaded a new change for review.
Change subject: Use update instead of save in update method
..
Use update instead of save in update method
Change-Id: Ia5bf0d42dbbda81d59e73f3ec17d7fbaa55b594e
---
M
backend/m
Saggi Mizrahi has uploaded a new change for review.
Change subject: Add missign storage_format_type arg to
Updatestorage_domain_static
..
Add missign storage_format_type arg to Updatestorage_domain_static
Change-Id: Ifc51ee4a52
Saggi Mizrahi has uploaded a new change for review.
Change subject: Run upgradeStoragePool on cluster compatibility change
..
Run upgradeStoragePool on cluster compatibility change
This will cause a pool to upgrade when the comp
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix potential NPE in ExportVmCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2436
To unsubscribe, visit http://
Maor Lipchuk has posted comments on this change.
Change subject: DO NOT SUBMIT core: refactor at AddVmCommand
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2291
To uns
Maor Lipchuk has posted comments on this change.
Change subject: DO NOT SUBMIT core: fixing abstract query tests
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2375
To
Maor Lipchuk has posted comments on this change.
Change subject: DO NOT SUBMIT core: Adding logic of query
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/bl
Maor Lipchuk has posted comments on this change.
Change subject: DO NOT SUBMIT core: New mechanism in CommandBase (rollback
using command)
..
Patch Set 1: (2 inline comments)
...
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add queries to VDC query type
..
Patch Set 3:
rebase since +1 from Yair
--
To view, visit http://gerrit.ovirt.org/2386
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: core:upgrade scripts numbering fix
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2417
To unsubscribe, visit http://gerrit.ov
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add query of get all quotas by user id
..
Patch Set 2:
Removed tabs from fixtures.xml as Yair commented
--
To view, visit http://gerrit.ovirt.org/2435
To
Moti Asayag has posted comments on this change.
Change subject: core: getting disk of vm and templates diffrently
..
Patch Set 1: (4 inline comments)
File
backend/manager/mo
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Adding tests for VdcQueryType
..
engine: Adding tests for VdcQueryType
Adding tests for queries, which validates whether the query name has
been added to
Moti Asayag has posted comments on this change.
Change subject: core: move interfaces and disks collections to VMBase
..
Patch Set 1: (4 inline comments)
File
backend/manage
Moti Asayag has posted comments on this change.
Change subject: core: Handle monitor special parameters
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/s
Maor Lipchuk has posted comments on this change.
Change subject: DO NOT SUBMIT common: Adding query params
..
Patch Set 3:
Since this class is in the common package it should be also added to
SharedGwt.gwt.xml
--
To view, vis
Moti Asayag has posted comments on this change.
Change subject: core: use VmBase refactoring to simplfy addImportedDisks and
addImportedInterfaces
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Moti Asayag has uploaded a new change for review.
Change subject: core: Fix potential NPE in ExportVmCommand
..
core: Fix potential NPE in ExportVmCommand
The vm.getInterfaces() is being referenced after it was verified to
be nu
Moti Asayag has posted comments on this change.
Change subject: core: Add OVF Resource type to oVirt device type mapping
..
Patch Set 1: (4 inline comments)
I proposed alternative for this enum, with lower maintenance.
...
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Add query of get all quotas by user id
..
Patch Set 1: (1 inline comment)
File backend/manager/modu
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Add queries to VDC query type
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2386
To unsubscr
Asaf Shakarchi has posted comments on this change.
Change subject: gwt: Removal of SharedGwt module
..
Patch Set 2:
The reason I added gwt-common dependency in userportal is because gwt-common
contains the backend gwt descript
Moti Asayag has posted comments on this change.
Change subject: core: remove unmanaged devices when a stateless VM is stopped
..
Patch Set 1: (1 inline comment)
If you don't plan on doing it, +2.
..
ovirt_engine - Build # 401 - Fixed:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/401/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Moti Asayag has posted comments on this change.
Change subject: core: Update VM devices on DB when hash changes
..
Patch Set 1: (15 inline comments)
File
backend/manager/mod
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fix ok button in new interface dialog (#783165)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2430
To
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add query of get all quotas by user id
..
engine: Add query of get all quotas by user id
Adding query for fetching all quotas by ad element id,
For GUI p
ovirt_engine - Build # 400 - Still Failing:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/400/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patche
ovirt_engine - Build # 399 - Failure:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/399/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Resizable table columns, take two
..
webadmin: Resizable table columns, take two
Improved the original concept submitted by Gilad.
This is a concept,
Moti Asayag has posted comments on this change.
Change subject: core: seperating code to enable working with cluster 3.0 and 3.1
..
--
To view, visit http://gerrit.ovirt.org/2409
To unsubscribe, visit http://gerrit.ovirt.org/s
Moti Asayag has posted comments on this change.
Change subject: core: seperating code to enable working with cluster 3.0 and 3.1
..
Patch Set 1: (6 inline comments)
File
bac
Michael Kublin has uploaded a new change for review.
Change subject: core : Adding support for multiple storage domains at
AddDiskToVmCommand
..
core : Adding support for multiple storage domains at AddDiskToVmCommand
The follo
Eli Mesika has posted comments on this change.
Change subject: core: enable null values for monitor, CD , Floppy is_plugged
property
..
Patch Set 1: (4 inline comments)
File
Eli Mesika has posted comments on this change.
Change subject: core: add helper methods to VmDeviceCommonUtils.
..
Patch Set 1: (2 inline comments)
File
backend/manager/modu
Eli Mesika has posted comments on this change.
Change subject: core: add FullListVdsCommand support
..
Patch Set 1: (10 inline comments)
File
backend/manager/modules/common/
ol...@redhat.com has posted comments on this change.
Change subject: restapi: support url params in rsdl
..
Patch Set 2: (1 inline comment)
fixed whitespace issues, 1 comment on your comment, rebasing and pushing again
...
Einav Cohen has submitted this change and it was merged.
Change subject: reports: added webadmin dashboards feature
..
reports: added webadmin dashboards feature
This patch contains 30 new dashboard reports (DRs), three ce repo
Einav Cohen has posted comments on this change.
Change subject: reports: added webadmin dashboards feature
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2429
To unsubscribe, visit http://g
Eli Mesika has posted comments on this change.
Change subject: core: Add functioality to XMLRpcStruct to process array of
XmlRpcStruct
..
Patch Set 1: (1 inline comment)
Com
Eli Mesika has posted comments on this change.
Change subject: core: Add functioality to XMLRpcStruct to process array of
XmlRpcStruct
..
Patch Set 1: (1 inline comment)
Fil
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: fix ok button in new interface dialog (#783165)
..
webadmin: fix ok button in new interface dialog (#783165)
https://bugzilla.redhat.com/show_bug.cg
Eli Mesika has posted comments on this change.
Change subject: core: Adding method to get the ISO domain of a data center
..
Patch Set 1: (2 inline comments)
File
backend/ma
Eli Mesika has posted comments on this change.
Change subject: core: Adding ManagedDevicesWhiteList configuration value
..
Patch Set 1: (3 inline comments)
File
backend/mana
Moti Asayag has posted comments on this change.
Change subject: core: add FullListVdsCommand support
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/vdsbroke
Eli Mesika has posted comments on this change.
Change subject: core: Adding ManagedDevicesWhiteList configuration value
..
Patch Set 1: (4 inline comments)
File
backend/mana
Moti Asayag has posted comments on this change.
Change subject: core: enable null values for monitor, CD , Floppy is_plugged
property
..
Patch Set 1: (4 inline comments)
Fil
Yaniv Dary has posted comments on this change.
Change subject: reports: added webadmin dashboards feature
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2429
Yaniv Dary has posted comments on this change.
Change subject: reports: added webadmin dashboards feature
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2429
Yaniv Dary has uploaded a new change for review.
Change subject: reports: added webadmin dashboards feature
..
reports: added webadmin dashboards feature
This patch contains 30 new dashboard reports (DRs), three ce reports
dashb
Eli Mesika has posted comments on this change.
Change subject: core: Adding string2Map method to StringUtils
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules
Moti Asayag has posted comments on this change.
Change subject: core: add helper methods to VmDeviceCommonUtils.
..
Patch Set 1: (2 inline comments)
File
backend/manager/mod
Michael Pasternak has posted comments on this change.
Change subject: restapi: Vm Start Time Displayed When Vm is Down
..
Patch Set 1:
Please rebase the change locally and upload again for review.
--
To view, visit http://gerr
Michael Pasternak has posted comments on this change.
Change subject: restapi: Vm Start Time Displayed When Vm is Down
..
--
To view, visit http://gerrit.ovirt.org/1701
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Moti Asayag has posted comments on this change.
Change subject: core: add FullListVdsCommand support
..
Patch Set 1: (9 inline comments)
File
backend/manager/modules/common/
Michael Pasternak has posted comments on this change.
Change subject: restapi: support url params in rsdl
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules/re
Michael Kublin has posted comments on this change.
Change subject: core : Clean up and optimization of different templates flows
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/242
Michael Kublin has submitted this change and it was merged.
Change subject: core : Clean up and optimization of different templates flows
..
core : Clean up and optimization of different templates flows
The following patch is a
Moti Asayag has posted comments on this change.
Change subject: core: Add functioality to XMLRpcStruct to process array of
XmlRpcStruct
..
Patch Set 1: (2 inline comments)
F
Eli Mesika has posted comments on this change.
Change subject: core: vm_device upgrade script patch
..
Patch Set 1: (7 inline comments)
The changes in sql code will be in a separate patch since I had to renumber the
upgrade pa
Oved Ourfali has posted comments on this change.
Change subject: DO NOT SUBMIT - wip - core: adding service policy for gluster
integration
..
Patch Set 3:
Changes in last commit:
1. Add the policy a method whether to check kvm
Yair Zaslavsky has posted comments on this change.
Change subject: core : Clean up and optimization of different templates flows
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2422
To unsub
Daniel Erez has submitted this change and it was merged.
Change subject: core : Returning storage_name back to DiskImage
..
core : Returning storage_name back to DiskImage
The following field was removed during one of the merge
Daniel Erez has posted comments on this change.
Change subject: core : Returning storage_name back to DiskImage
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2426
To unsubscribe,
Juan Hernandez has posted comments on this change.
Change subject: restapi: Remove Spring Framework
..
Patch Set 2:
Updated to use RESTEasy 2.3.2.Final which fixes the problem with the "/" URL.
Bad news is that as we are depen
Michael Kublin has uploaded a new change for review.
Change subject: core : Returning storage_name back to DiskImage
..
core : Returning storage_name back to DiskImage
The following field was removed during one of the merge. Ret
ovirt_engine_gwt_user-gwtp - Build # 205 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/205/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman
Moti Asayag has posted comments on this change.
Change subject: core: Adding method to get the ISO domain of a data center
..
Patch Set 1: (2 inline comments)
Good refactor.
Mike Kolesnik has posted comments on this change.
Change subject: core: Fixes in SnapshotsManager
..
Patch Set 3: (2 inline comments)
File
backend/manager/modules/bll/src/ma
1 - 100 of 133 matches
Mail list logo
