Moti Asayag has posted comments on this change.
Change subject: core: getting disk of vm and templates diffrently
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 369: VM vm =
DbFacade.getInstance().getVmDAO().get(vmBaseInstance.getId());
this means that you must push all of the patchset as once, else you'll break
the build.
So either do so, or move this line to its proper commit.
Line 457: if (entity instanceof VmTemplate) {
you don't the instanceof - it is in the VmBase.
....................................................
Commit Message
Line 7: core: getting disk of vm and templates diffrently
s/diffrently/differently
Line 17: I will be happy to get any comments or suggestions for improvements on
that.
As long as you take care to initialize the VmStatic from the getters of
getDiskInfo, getImages and getIntefaces, the same functionality should remain
exactly the same.
--
To view, visit http://gerrit.ovirt.org/2416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9726492eb401b5c86562757905c2fd84b7c12ffc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
