Maor Lipchuk has posted comments on this change. Change subject: Refactor UpdateStoragePoolCommand ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java Line 113: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE); You didn't responded to my comment from last patch. You are adding the update action after you already returned false on failure. The action will never be set to update. -- To view, visit http://gerrit.ovirt.org/2275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0978ffd7f22c19c58c8a2c6f1f9feafabb3cdf5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
