Eli Mesika has posted comments on this change.
Change subject: core: add FullListVdsCommand support
......................................................................
Patch Set 1: (10 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FullListVDSCommandParameters.java
Line 14: * seperated Vm Id list)
yea, right , history .... fixed
Line 16: */
Done
Line 19: public class FullListVDSCommandParameters extends
VdsIdAndVdsVDSCommandParametersBase {
no, there is already list that gives only id and status , the FULL is the term
used by VDSM
Line 31:
Done
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FullListVdsCommand.java
Line 11: @Logged(executionLevel = LogLevel.TRACE)
removed
Line 12: public class FullListVdsCommand<P extends
VdsIdAndVdsVDSCommandParametersBase> extends VdsBrokerCommand<P> {
Done
Name is OK
Line 20: protected void ExecuteVdsBrokerCommand() {
Done
Line 23: fullVmListReturn = getBroker().list("true", vmIdsArray);
Done
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
Line 32:
Done
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
Line 27: public Map<String, Object> list(String mode, String[] vmIds);
Done
--
To view, visit http://gerrit.ovirt.org/2406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieda51634469d3925a9afa89970d60a5427144e98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
