Moti Asayag has posted comments on this change. Change subject: core: Add functioality to XMLRpcStruct to process array of XmlRpcStruct ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcStruct.java Line 59: Map[] map = new Map[devices.length]; why do you rather using primitive array, untyped vs typed List<Map<String, Object>> ? .................................................... Commit Message Line 9: Since in the new format we have nested XMLRpcStruct (like the address and specParams) , we need a mathod that s/mathod/method -- To view, visit http://gerrit.ovirt.org/2405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I859bb885798f64e236e4d00043bddde39887cbc6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
