Moti Asayag has posted comments on this change.
Change subject: core: Adding method to get the ISO domain of a data center
......................................................................
Patch Set 1: (2 inline comments)
Good refactor.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAOWrapperImpl.java
Line 200: if (domain.getstorage_domain_type() ==
StorageDomainType.Master) {
not that this file should be supported, but for the sake of consistency - the
condition will always fail for ISO.
You have to compare it against the given type
....................................................
Commit Message
Line 10: This patch adds this ability and refctors the code.
s/refctors/refactors
--
To view, visit http://gerrit.ovirt.org/2404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbbb55fd3cb332b155796c48212ba3f7c4b59ccc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
