Moti Asayag has posted comments on this change.
Change subject: core: add helper methods to VmDeviceCommonUtils.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
Line 85: final String DEVICE = "deviceId=";
Same strings appears in VmDeviceUtils.appendDeviceIdToSpecParams
So it worth putting this as public in the common.
BTW, what is the difference between VmDeviceUtils.appendDeviceIdToSpecParams
and this ? looks almost the same.
Line 108: sb.append(" ");
does it mean that the last character in the white list should be blank space ?
--
To view, visit http://gerrit.ovirt.org/2407
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcc9d03601cf34becd0b5767cb6702e537860449
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
