Michael Pasternak has posted comments on this change.
Change subject: restapi: support url params in rsdl
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2226: <xs:complexType name="Parameter">
please remove white space
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 10: case-sensitive: {context: matrix, type: 'xs:boolean',
description: true|false}
please remove all white spaces
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
Line 323: Object value =
action.getRequest().getUrlparams().get(key);
IIRC you changing object to string in Request, so no need for 'Object value'
--
To view, visit http://gerrit.ovirt.org/1193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a24adb29e7df04d510d725cb6bed3dd619a482
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
