Eli Mesika has posted comments on this change.
Change subject: core: Update VM devices on DB when hash changes
......................................................................
Patch Set 1: (15 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 765: if
(!VmDeviceCommonUtils.isOldClusterVersion(_vds.getvds_group_compatibility_version()))
{
this is called when VM is turning from Down to WaitForLunch at the first time
and each time the VM hash is changed . VDSM will not pass us non running VMs
hash as dirty
Line 795: for (java.util.Map.Entry<VmDynamic, VmStatistics> vm_helper :
_runningVms.values()) {
Done
Line 797: String dbHash = _vmDict.get(vm.getId()).getHash();
Done
Line 801: vm.setHash(vm.getHash());
Done
Line 825: private XmlRpcStruct[] getVmInfo(List<String> vmsToUpdate) {
This is one verb that calls VDSM to get all device updates of VMs with dirty
hash, if this fails we really can not update anything
Line 845: int i = 0;
Done
Line 857: log.infoFormat("Recieved a Device without an address
when processing VM devices, skipping device: {0}.",
Done
Line 866:
DbFacade.getInstance().getVmDeviceDAO().update(vmDevice);
Done
Line 883: if (device.getIsPlugged()) {
Done
Line 888:
DbFacade.getInstance().getVmDeviceDAO().update(device);
Done
Line 892:
DbFacade.getInstance().getVmDeviceDAO().remove(device.getId());
Done
Line 903: */
Done
Line 912: Object o = device.getItem("specParams");
Done
Line 915: specParams = ((Map<String, String>) o).toString();
but this is what the api defines , I am not expected to get anything else, what
do you suggest.
Line 924: DbFacade.getInstance().getVmDeviceDAO().save(newDevice);
Done
--
To view, visit http://gerrit.ovirt.org/2410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia963db83d88cb11c57be197c40d64f1e1b3c88c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
