Eli Mesika has posted comments on this change.
Change subject: core: move interfaces and disks collections to VMBase
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 32: private java.util.ArrayList<DiskImage> images;
Done
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 80: mVmStatic.setImages(new java.util.ArrayList<DiskImage>());
Done
Line 1099: if (mVmStatic == null)
please see SetVmStatusVDSCommand line 27 :
VM vm = new VM(null, vmDynamic, vmStatistics);
Line 1109: public java.util.ArrayList<DiskImage> getImages() {
See my prev answer , this code may need re-factoring but IMHO it is out of the
scope of this patch
--
To view, visit http://gerrit.ovirt.org/2413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18be17cdcad37d4940b99cbad6dc3abaf04d8595
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
