Moti Asayag has posted comments on this change. Change subject: core: move interfaces and disks collections to VMBase ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java Line 1099: if (mVmStatic == null) I see there is a reference to the vm.getInterfaces(), so I assume there should be a valid copy of it. No harm should happen in this use case if the vmStatic is being initialized, since not being used in that flow, just the getInterfaces() -- To view, visit http://gerrit.ovirt.org/2413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18be17cdcad37d4940b99cbad6dc3abaf04d8595 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
