Moti Asayag has posted comments on this change.
Change subject: core: Handle monitor special parameters
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 102: else if
(device.getType().equalsIgnoreCase(VmDeviceType.VIDEO.name())) {
it is safer to perform the comparison the other way:
VmDeviceType.VIDEO.name().equalsIgnoreCase(device.getType())
no risk for NPE.
--
To view, visit http://gerrit.ovirt.org/2415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9198a5870b321bd49dca28f202c990e564c89340
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
